FIPS alignment#49
Merged
Merged
Conversation
- Removed -DWOLFSSL_ECDSA_DETERMINISTIC_K from the FIPS ./configure; - Removed unused function is_hash_type_fips; - Added various HAVE_FIPS gates with proper alternatives for the FIPS build; - Added various WC_RNG_SEED_CB callbacks; - Updated the tests;
…used; - Fixed memory leak in wolfssl_pk_generate_keys_dh;
SparkiDev
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• drop -DWOLFSSL_ECDSA_DETERMINISTIC_K from FIPS build
• remove unused is_hash_type_fips
• add/adjust HAVE_FIPS guards and WC_RNG_SEED_CB callbacks
• log digest algorithm used
• fix leak in wolfssl_pk_generate_keys_dh
• update tests to new FIPS constraints